Skip to content

Commit 380ef52

Browse files
committed
Merge pull request #1595 from will-in-wi/rubocop_housekeeping
Rubocop housekeeping
2 parents b4f485d + 863145f commit 380ef52

File tree

4 files changed

+9
-10
lines changed

4 files changed

+9
-10
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ rvm:
55
- 2.1
66
- 2.0
77
- rbx-2
8-
script: bundle exec rake spec lint
8+
script: bundle exec rake spec rubocop
99
install: bundle install --jobs=1
1010
cache: bundler
1111
branches:

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ default of Capistrano 3.4.0 and earlier.
1717

1818
Other changes:
1919

20+
* Internal Rubocop cleanups.
2021
* `remove` DSL method for removing values like from arrays like `linked_dirs`
2122
* `append` DSL method for pushing values like `linked_dirs`
2223
[#1447](https://github.com/capistrano/capistrano/pull/1447),

DEVELOPMENT.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,11 @@ Currently, the Capistrano Travis build does *not* run the Cucumber suite. This m
5555

5656
## Coding guidelines
5757

58-
This project uses [RuboCop](https://github.com/bbatsov/rubocop) to enforce standard Ruby coding guidelines. Currently we run RuboCop's lint rules only, which check for readability issues like indentation, ambiguity, and useless/unreachable code.
58+
This project uses [RuboCop](https://github.com/bbatsov/rubocop) to enforce standard Ruby coding guidelines.
5959

60-
* Test that your contributions pass with `rake lint`
61-
* The linter is also run as part of the full test suite with `rake`
62-
* Note the Travis build will fail and your PR cannot be merged if the linter finds errors
60+
* Test that your contributions pass with `rake rubocop`
61+
* Rubocop is also run as part of the full test suite with `rake`
62+
* Note the Travis build will fail and your PR cannot be merged if Rubocop finds errors
6363

6464
## Submitting a pull request
6565

Rakefile

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,10 @@ require "cucumber/rake/task"
33
require "rspec/core/rake_task"
44
require "rubocop/rake_task"
55

6-
task :default => [:spec, :lint]
6+
task :default => [:spec, :rubocop]
77
RSpec::Core::RakeTask.new
88

99
Cucumber::Rake::Task.new(:features)
1010

11-
desc "Run RuboCop lint checks"
12-
RuboCop::RakeTask.new(:lint) do |task|
13-
task.options = ["--lint"]
14-
end
11+
desc "Run RuboCop checks"
12+
RuboCop::RakeTask.new

0 commit comments

Comments
 (0)