Infinite loop issue

Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "netflow_parser"
 description = "Parser for Netflow Cisco V5, V7, V9, IPFIX"
-version = "0.2.0"
+version = "0.2.1"
 edition = "2021"
 author = "[email protected]"
 license = "MIT OR Apache-2.0"

RELEASES.md

@@ -1,3 +1,6 @@
+# 0.2.1
+  * Fixed issue where no ipfix template fields can infinite loop.
+
 # 0.2.0
   * Clippy updates for 1.76
   * Removed dbg! macros for now for performance reason until we have a better solution.

SECURITY.md

@@ -4,6 +4,7 @@
 
 | Version | Supported          |
 | ------- | ------------------ |
+| 0.2.1   | :white_check_mark: |
 | 0.2.0   | :white_check_mark: |
 | 0.1.9   | :white_check_mark: |
 | 0.1.8   | :white_check_mark: |

src/lib.rs

@@ -408,6 +408,21 @@ mod tests {
         assert_yaml_snapshot!(parser.parse_bytes(&packet));
     }
 
+    #[test]
+    fn it_parses_ipfix_with_no_template_fields_raises_error() {
+        let packet = [
+            0, 10, 0, 26, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 0, 0, 1, 2, 0, 10, 0, 8, 0, 0, 1, 1,
+        ];
+        let template = IPFixTemplate {
+            field_count: 2,
+            template_id: 258,
+            fields: vec![],
+        };
+        let mut parser = NetflowParser::default();
+        parser.ipfix_parser.templates.insert(258, template);
+        assert_yaml_snapshot!(parser.parse_bytes(&packet));
+    }
+
     #[test]
     fn it_parses_ipfix_options_template() {
         let packet = [

src/snapshots/netflow_parser__tests__it_parses_ipfix_with_no_template_fields_raises_error.snap

@@ -0,0 +1,34 @@
+---
+source: src/lib.rs
+expression: parser.parse_bytes(&packet)
+---
+- Error:
+    error_message: "Could not parse v10_set: Parsing Error: Error { input: [0, 8, 0, 0, 1, 1], code: Fail }"
+    bytes:
+      - 0
+      - 10
+      - 0
+      - 26
+      - 0
+      - 0
+      - 0
+      - 1
+      - 0
+      - 0
+      - 0
+      - 1
+      - 0
+      - 0
+      - 0
+      - 0
+      - 1
+      - 2
+      - 0
+      - 10
+      - 0
+      - 8
+      - 0
+      - 0
+      - 1
+      - 1
+

src/variable_versions/ipfix.rs

@@ -220,6 +220,11 @@ fn parse_fields<T: CommonTemplateFields>(
             return Err(NomErr::Error(NomError::new(i, ErrorKind::Fail)));
         }
     };
+    // If no fields there are no fields to parse
+    if template.get_fields().is_empty() {
+        // dbg!("Template without fields!");
+        return Err(NomErr::Error(NomError::new(i, ErrorKind::Fail)));
+    };
     let mut fields = vec![];
     let mut remaining = i;
     while !remaining.is_empty() {