Handled unknown response objects that contain json body #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlanin
reviewed
Jul 12, 2018
|
|
||
| $content = $response->getContent(); | ||
|
|
||
| return json_decode($content, true) ?: false; |
There was a problem hiding this comment.
Please, add json_last_error() check
There was a problem hiding this comment.
The goal here is to 'try' to decode the content, if it fails, we don't need to know the reason, just that it's not a valid json content (this is just to try and guess if it's actually a response with a json content).
If there is no error we do our thing, otherwise, just let it go
There was a problem hiding this comment.
Please merge this! I'm using dingo and it didn't work until I updated debugger.php with this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dingo uses it's custom Response object that, unfortunately, does not extend
JsonResponseThe changes that I've made are not limited to Dingo responses, in any
Responseobject has a json content-type (we assume that has a json body) we'll handle the debug workflow as intended.Hope that can help someone else 😄