Skip to content

feat: add config option to change response key #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 31, 2019
Merged

feat: add config option to change response key #20

merged 5 commits into from
Oct 31, 2019

Conversation

mycarrysun
Copy link

Features

  • Add a config option to allow the developer to change the response key that the debugger uses
    • This prevents naming conflicts with other libraries that also attach to the debug key in responses

mlanin
mlanin reviewed Oct 3, 2019
View reviewed changes
Mike Harrison added 4 commits October 4, 2019 14:31
add const to Debugger class for default response key
cf29732 
init $responseKey as the default response key
moved setting the response key from config into the service provider
make sure key is not empty
de53ed2
feat: add getter for response key
c0eff15
test: added test for setting response key
0cbfc52
@mycarrysun
Copy link
Author

Thanks for being patient - test is now added! @mlanin

@mlanin
Copy link
Owner

mlanin commented Oct 31, 2019

Thank you so much! This is awesome 👍

@mlanin mlanin merged commit 2474809 into mlanin:master Oct 31, 2019
@mycarrysun mycarrysun deleted the response-key branch October 31, 2019 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlanin mlanin mlanin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mycarrysun @mlanin