add timeout_sec as keyword parameter #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for submitting this, I really appreciate it and it looks great! Since the documentation is built automatically, there are a few things I need to add/change before merging so there aren't any issues with version numbers and things like that. |
|
Glad to help - it was a good learning experience for me. Good luck with the docs ! |
tannewt
pushed a commit
to adafruit/CircuitPython_Community_Bundle
that referenced
this pull request
Mar 5, 2018
Updating https://github.com/mmabey/CircuitPython_HCSR04 to v0.2 from v0.1: > add timeout_sec as keyword parameter (mmabey/CircuitPython_HCSR04#2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add timeout_sec keyword parameter. This sets a timeout while waiting for an echo return. Default set to .1 sec. This is meant to address issue #1