Adding StreamableHttpServerTransportProvider class and unit tests #290
+1,162
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZachGerman
commented
Jun 2, 2025
| */ | ||
| public class StreamableHttpSseStream { | ||
|
|
||
| private final Sinks.Many<SseEvent> eventSink = Sinks.many().multicast().onBackpressureBuffer(); |
There was a problem hiding this comment.
Meant to change this to unicast. Will address.
ZachGerman
commented
Jun 2, 2025
|
|
||
| private String mcpEndpoint; | ||
|
|
||
| private Supplier<String> sessionIdProvider = () -> UUID.randomUUID().toString(); |
There was a problem hiding this comment.
Should change the value here to DEFAULT_SESSION_ID_PROVIDER. Will address.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still missing:
Motivation and Context
Trying to reach spec parity with TS and Python for Java. Will continue working on other aspects of this.
How Has This Been Tested?
Unit tests and integ tests using a partially-complete sHTTP client transport class, but I didn't include the integ test file as the client isn't complete.
Breaking Changes
N/A
Types of changes
Checklist
Additional context
This is part of a larger commit seen here: #289