Skip to content

RFC: Lower log levels used for connections #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

nickcoai
Copy link
Contributor

It's not ideal, but currently some servers encode authorization in their URI. To reduce risk of such servers in other situations lower the log level of messages including the URI so we don't log potentially auth-containing data by default.

Motivation and Context

As above really, it could be done by altering log levels but it's unclear this granularity is needed so instead proposing changing it.

How Has This Been Tested?

Ran locally

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

N/A

Copy link
Contributor

@ihrpr ihrpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

ugh, yeah, we need to implement proper URI sanitization, adding to the list. For now it's Okay to lower the level.

@ihrpr ihrpr merged commit 532b117 into modelcontextprotocol:main May 27, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants