Deleted hanging prompt_manager.py module since no file was using it.
#864
+0
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElGreKost
changed the title
ElGreKost
changed the title
prompt_manager.py module since no file was using it.
Kludex
reviewed
Jun 2, 2025
There was a problem hiding this comment.
I think this is a file by itself? https://github.com/jlowin/fastmcp/blob/97ef80c62478d0f366d62baf3e15875937cd7b9f/src/fastmcp/prompts/prompt_manager.py#L5
|
Not in the modelcontextprotocol:main where I PR. You show me a different fork from jlowin In the main repo in prompts folder There are the And what I'm saying is they both implement class PromptManger but the And that's why this should be deleted. (and to be consistent with the tools directory Maybe even rename the manager to prompt_manager like the tool_manager in tools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted the file prompt_manager.py since now all the files in the directory use the improved version of it that is manager.py