Skip to content

fix: Expose completions capability #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -877,13 +877,13 @@ The MCP protocol defines three core primitives that servers can implement:

MCP servers declare capabilities during initialization:

| Capability | Feature Flag | Description |
|-------------|------------------------------|------------------------------------|
| `prompts` | `listChanged` | Prompt template management |
| `resources` | `subscribe`<br/>`listChanged`| Resource exposure and updates |
| `tools` | `listChanged` | Tool discovery and execution |
| `logging` | - | Server logging configuration |
| `completion`| - | Argument completion suggestions |
| Capability | Feature Flag | Description |
|--------------|------------------------------|------------------------------------|
| `prompts` | `listChanged` | Prompt template management |
| `resources` | `subscribe`<br/>`listChanged`| Resource exposure and updates |
| `tools` | `listChanged` | Tool discovery and execution |
| `logging` | - | Server logging configuration |
| `completions`| - | Argument completion suggestions |

## Documentation

Expand Down
6 changes: 6 additions & 0 deletions src/mcp/server/lowlevel/server.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ def get_capabilities(
resources_capability = None
tools_capability = None
logging_capability = None
completions_capability = None

# Set prompt capabilities if handler exists
if types.ListPromptsRequest in self.request_handlers:
Expand All @@ -209,12 +210,17 @@ def get_capabilities(
if types.SetLevelRequest in self.request_handlers:
logging_capability = types.LoggingCapability()

# Set completions capabilities if handler exists
if types.CompleteRequest in self.request_handlers:
completions_capability = types.CompletionsCapability()

return types.ServerCapabilities(
prompts=prompts_capability,
resources=resources_capability,
tools=tools_capability,
logging=logging_capability,
experimental=experimental_capabilities,
completions=completions_capability,
)

@property
Expand Down
10 changes: 10 additions & 0 deletions src/mcp/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,12 @@ class LoggingCapability(BaseModel):
model_config = ConfigDict(extra="allow")


class CompletionsCapability(BaseModel):
"""Capability for completions operations."""

model_config = ConfigDict(extra="allow")


class ServerCapabilities(BaseModel):
"""Capabilities that a server may support."""

Expand All @@ -280,6 +286,10 @@ class ServerCapabilities(BaseModel):
"""Present if the server offers any resources to read."""
tools: ToolsCapability | None = None
"""Present if the server offers any tools to call."""
completions: CompletionsCapability | None = None
"""
Present if the server offers autocompletion suggestions for prompts and resources.
"""
model_config = ConfigDict(extra="allow")


Expand Down
22 changes: 22 additions & 0 deletions tests/server/test_session.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,13 @@
from mcp.shared.session import RequestResponder
from mcp.types import (
ClientNotification,
Completion,
CompletionArgument,
CompletionsCapability,
InitializedNotification,
PromptReference,
PromptsCapability,
ResourceReference,
ResourcesCapability,
ServerCapabilities,
)
Expand Down Expand Up @@ -88,6 +93,7 @@ async def test_server_capabilities():
caps = server.get_capabilities(notification_options, experimental_capabilities)
assert caps.prompts is None
assert caps.resources is None
assert caps.completions is None

# Add a prompts handler
@server.list_prompts()
Expand All @@ -97,6 +103,7 @@ async def list_prompts():
caps = server.get_capabilities(notification_options, experimental_capabilities)
assert caps.prompts == PromptsCapability(listChanged=False)
assert caps.resources is None
assert caps.completions is None

# Add a resources handler
@server.list_resources()
Expand All @@ -106,6 +113,21 @@ async def list_resources():
caps = server.get_capabilities(notification_options, experimental_capabilities)
assert caps.prompts == PromptsCapability(listChanged=False)
assert caps.resources == ResourcesCapability(subscribe=False, listChanged=False)
assert caps.completions is None

# Add a complete handler
@server.completion()
async def complete(
ref: PromptReference | ResourceReference, argument: CompletionArgument
):
return Completion(
values=["completion1", "completion2"],
)

caps = server.get_capabilities(notification_options, experimental_capabilities)
assert caps.prompts == PromptsCapability(listChanged=False)
assert caps.resources == ResourcesCapability(subscribe=False, listChanged=False)
assert caps.completions == CompletionsCapability()


@pytest.mark.anyio
Expand Down
Loading