Skip to content

fix: resolve registry image conflict in docker-compose #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

8806667653
Copy link

Issue: links directive was failing on podman

  • Removed unsupported 'links' directive for Podman compatibility

It was failing on Podman because Podman doesn't support the links directive that Docker Compose does, and we already using depends_on, which establishes the dependency relationship between services; we can simply remove the links section from your docker-compose.yml file.

Motivation and Context

docker-compose -links deprecated #107
Fix the defect by removing link.

How Has This Been Tested?

Yes. Test by running on both.
For Docker run.
docker build -t registry .
docker compose up

For Podman
podman build -t registry .
podman compose up

Breaking Changes

Yes for podman.

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [ x] Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • [x ] I have read the MCP Documentation
  • [ x] My code follows the repository's style guidelines
  • [ x] New and existing tests pass locally
  • [ x] I have added appropriate error handling
  • [x ] I have added or updated documentation as needed

Additional context

It is related to issue #107

Issue: links directive was failing on podman

- Removed unsupported 'links' directive for Podman compatibility
Copy link
Contributor

@yshngg yshngg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@8806667653
Copy link
Author

Please merge this or i do need to do anything else for merging.

@yshngg
Copy link
Contributor

yshngg commented Jun 9, 2025

Hi @toby , review complete, merge please 🙏 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants