fix: resolve registry image conflict in docker-compose #114
+0
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: links directive was failing on podman
It was failing on Podman because Podman doesn't support the links directive that Docker Compose does, and we already using depends_on, which establishes the dependency relationship between services; we can simply remove the links section from your docker-compose.yml file.
Motivation and Context
docker-compose -links deprecated #107
Fix the defect by removing link.
How Has This Been Tested?
Yes. Test by running on both.
For Docker run.
docker build -t registry .
docker compose up
For Podman
podman build -t registry .
podman compose up
Breaking Changes
Yes for podman.
Types of changes
Checklist
Additional context
It is related to issue #107