Fixing Windows, using npx command

[laopo001]

Motivation and Context

Fixing Windows, using npx command

How Has This Been Tested?

Yes, I have tested this modification on Windows.
cross-spawn is a very general library, resolve various issues that Node encounters when using spawn on Windows.

Breaking Changes

No

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update

Checklist

• I have read the MCP Documentation
• My code follows the repository's style guidelines
• New and existing tests pass locally
• I have added appropriate error handling
• I have added or updated documentation as needed

Additional context

No

[anaisbetts]

@laopo001 In Claude Desktop, we fix this via spawn-rx which does similar Windows-specific fixups but it might be nice to have this work for other MCP clients

[jspahrsummers]

Thanks, this seems useful!

Can you please share the sorts of tests that you ran to verify this works? Even better would be if it's possible to write some automated tests for this somehow. 🙏

[dinhphieu]

Is this fixing this kind of issue? For some reason, on my Windows machine, StdioClientTransport can't seem to find npx anywhere in PATH

const githubTransport = new StdioClientTransport({
        command: "npx",
        args: ["-y", "@modelcontextprotocol/server-github"],
        env: {
            GITHUB_PERSONAL_ACCESS_TOKEN: process.env.GITHUB_PERSONAL_ACCESS_TOKEN!
        }
    });

Error: spawn npx ENOENT
    at Process.ChildProcess._handle.onexit (node:internal/child_process:286:19)
    at onErrorNT (node:internal/child_process:484:16)
    at processTicksAndRejections (node:internal/process/task_queues:90:21) {
  errno: -4058,
  code: 'ENOENT',
  syscall: 'spawn npx',
  path: 'npx',
  spawnargs: [ '-y', '@modelcontextprotocol/server-github' ]
}

[zhibisora]

I added a test for this pr in #198

Can someone go there to have a review?

[laopo001]

What else do I need to do?

[jspahrsummers]

@laopo001 Please see my comment above.

[jspahrsummers]

Superseded by #198.