-
Notifications
You must be signed in to change notification settings - Fork 91
Add Input2d layer #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Input2d layer #198
Conversation
Thank you for your effort, Milan! Great job figuring out such a handsome solution for generics! Looks really nice. However, there are several pieces missing for the plumbing part:
Should I add them together with an example in my PR? |
@OneAdder indeed, you're right. If a network begins with a 2-d input layer, then the specific forward, predict, and backward methods need to be added as well. If you don't mind, yes, please go ahead and add them. You should be able to push directly to this PR (rather than a separate PR) by cloning my fork at milancurcic/neural-fortran and checking out the |
@milancurcic I made the updates for |
Awesome, thanks! I'll take another read through and test locally tonight. |
Adds
input2d
layer.This also changes how input layers of various ranks are constructed.
Currently Fortran generic name can't distinguish between
input([10, 10])
andinput([10, 10, 10])
(1-d array as input), but it can distinguish betweeninput(10, 10)
andinput(10, 10, 10)
(multiple scalars as input).Before:
This PR:
@OneAdder please review.
This PR is in support of removing the crutch in #197.
TODO:
network % {forward,predict,predict_batch}_2d
input2d
testsinput2d
example