-
Notifications
You must be signed in to change notification settings - Fork 91
Generic conv & maxpool #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic conv & maxpool #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Here are some suggestions
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
Co-authored-by: Jeremie Vandenplas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Great. Just to give an update, I started writing some code for my pr poolings but i think i'll be busy until June. |
@ricor07 no problem at all, whenever you're ready. |
This PR makes
conv1d
andconv2d
accessible under a generic nameconv
.Same for
maxpool
, except that here we have to makestride
a required argument due to interface ambiguity when it's optional.An example CNN with the new API is now:
or, without keywords:
This is mainly a style choice; I can see pros and cons to either approach. I'm curious what you think.