cleanup function issue #3860
Merged
cleanup function issue #3860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appInjector exports function named "unmount" for cleanup so changed the wrong imported and used function
|
@parthbt143 is attempting to deploy a commit to the Module Federation Team on Vercel. A member of the Team first needs to authorize it. |
|
|
ScriptedAlchemy
approved these changes
May 9, 2024
|
Thanks. There is a way to do this via a runtime plugin so this mount method is outdated but not yet replaced. I think I have a pr open for multi react app mounts that does it automatically by just importing code that uses different react major |
ScriptedAlchemy
merged commit d86eed9
into
module-federation:master
1 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appInjector exports function named "unmount" for cleanup so changed the wrong imported and used function