Make webpack play better with browserify #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mohsen1 any guidance? I've fixed various configuration issues with updating webpack/karma-webpack/etc, but I'm not sure what's up with the tests now? |
|
Let me checkout the branch and see |
|
Funny tests pass on my machine! Not sure what's going on? I was thinking of switching to yarn for this project. Do you want to do that as well? |
|
I'm not sure I have time to undertake much more work on this for now. These changes make the project work for me in our browserify-based SPA. We're currently using my branch. Would love to get these changes mainlined and switch back to the npm-published version. |
|
I'll try to merge and publish this soon |
|
Please, really need this pull request to be merged. |
mohsen1
approved these changes
Mar 30, 2017
|
Released at version 2.0 Let me know if you have any problems |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will cause a dead code path that would cause browserify problems to be removed. The dead code path had to do with hot module reloading, which appeared to be turned off, but browserify would still find the require() statement with a weird file path in it.
This change also seems to shave a good 15KB off the dist file by running it through UglifyJS, even without any compression or mangling (probably due to comment removal).
Willing to discuss, but this fixed things so I could use this with my browserify setup.