Skip to content

Generate TypeScript definition file #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

protyposis
Copy link
Contributor

This pull request changes the configuration to generate a TypeScript definition file that is referenced from the package.json. It is then possible to import this package into TypeScript (import JSONFormatter from 'json-formatter-js';).

In the meantime, the NPM package is available as json-formatter-js-ts.

@mohsen1
Copy link
Owner

mohsen1 commented Apr 24, 2017

This is great!

Why build is failing?

@protyposis
Copy link
Contributor Author

It was already broken without my changes so I didn't investigate.

@mohsen1 mohsen1 merged commit 48c3136 into mohsen1:master Apr 24, 2017
@mohsen1 mohsen1 mentioned this pull request Apr 25, 2017
@protyposis
Copy link
Contributor Author

Thanks for this nice library and accepting the pull request :) I unpublished the temporary json-formatter-js-ts package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants