Skip to content

Update directive when schema parameter changes #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2016

Conversation

rbren
Copy link
Contributor

@rbren rbren commented Mar 10, 2016

Here's my use case:

<json-schema-view schema="mySchema"></json-schema-view>

where mySchema can change over time. Currently, when mySchema changes, the structure of the schema displayed stays the same, and all the fields disappear.

I just added a $scope.$watch('schema') to reinitialize all variables when the schema changes, per stack overflow:
http://stackoverflow.com/questions/20856824/angular-directive-refresh-on-parameter-change

mohsen1 added a commit that referenced this pull request Mar 11, 2016
Update directive when schema parameter changes
@mohsen1 mohsen1 merged commit 90cb20d into mohsen1:master Mar 11, 2016
@mohsen1
Copy link
Owner

mohsen1 commented Mar 11, 2016

@rbren
Copy link
Contributor Author

rbren commented Mar 11, 2016

Awesome thanks for the quick turnaround!

Bobby Brennan
[email protected]

On Thu, Mar 10, 2016 at 8:37 PM, Mohsen Azimi [email protected]
wrote:

This is released under
https://github.com/mohsen1/json-schema-view/releases/tag/v0.5.0


Reply to this email directly or view it on GitHub
#20 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants