Make entire public API C-compatible #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # clip.cpp # clip.h # examples/main.c
|
I think it looks good overall. One thing in my mind is, maybe we can accept |
Either that or provide a function that produces the batch struct given a std::vector. |
|
Yes, maybe a util function in the |
monatis
added a commit
that referenced
this pull request
Sep 14, 2023
…ble (#58) * rm __pycache__ * gitignore __pycache__ * gitignore dist * Refactor encoding functions to make normalization optional * Fix pip package #55 * Make entire public API C-compatible (#58) * main.c: remove hardcoded vec_dim * Make all public functions use C-compatible signatures * Move private declarations to clip.cpp * Merge with fix-zsl * Update examples * python: rm redundant bindings to CLIPLayer and models * formatting: apply formatting script * readme: add notices about the new API * zsl: use const auto & * tests: fix benchmark utility * python: bump version * Add constructor-like functions for batched structs --------- Co-authored-by: M. Yusuf Sarıgöz <[email protected]> --------- Co-authored-by: Denis Ismailaj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.