Skip to content

test(NODE-6358): handle directories in bson versions #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

durran
Copy link
Member

@durran durran commented Sep 4, 2024

Description

Fixes benchmark test names when the bson version points at a directory, eg bson:/path/to/bson.

What is changing?

Updates regex to strip from ":"

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6358

Double check the following

  • Ran npm run check:eslint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran
Copy link
Member Author

durran commented Sep 4, 2024

Test failures unrelated, pass locally.

@nbbeeken nbbeeken self-assigned this Sep 4, 2024
@nbbeeken nbbeeken added the Primary Review Pull request is being reviewed by primary reviewer label Sep 4, 2024
@nbbeeken nbbeeken self-requested a review September 4, 2024 15:57
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we address the failing test? (Can skip)

@durran
Copy link
Member Author

durran commented Sep 4, 2024

Skipped test and added todo.

@durran durran requested a review from nbbeeken September 4, 2024 16:17
@nbbeeken nbbeeken merged commit b2d505f into main Sep 4, 2024
4 checks passed
@nbbeeken nbbeeken deleted the NODE-6358 branch September 4, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review Pull request is being reviewed by primary reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants