chore: import from https://github.com/mongodb-js/devtools-connect COMPASS-7645 #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paula-stacho
changed the title
addaleax
reviewed
Feb 16, 2024
This reverts commit f2c0792.
paula-stacho
force-pushed
the
COMPASS-7645
branch
from
ea154e1 to
9d626d7
Compare
addaleax
reviewed
Feb 20, 2024
paula-stacho
force-pushed
the
COMPASS-7645
branch
from
cdecf3f to
0b49d0d
Compare
addaleax
approved these changes
Feb 20, 2024
mcasimir
reviewed
Feb 20, 2024
| 'plugin:promise/recommended', | ||
| 'plugin:@typescript-eslint/recommended', | ||
| ], | ||
| rules: { |
There was a problem hiding this comment.
is fine for a follow up, but generally we try to avoid having special rules and plugins for packages in the monorepo, and instead we align on eslint / ts when we move things here, that way we can keep maintaining everything in the same way, especially for stuff that can be just addressed with eslint --fix
There was a problem hiding this comment.
yeah, this will have to be a follow up 🙈 . I mention this in the description - I have tried to make this work with the same rulesets as the other packages, but I kept seeing errors that I couldn't even figure out where they were coming from. so in the end I gave up and used the old eslint config + a couple of exceptions to support the new prettier config.
saisrinivas795
approved these changes
Feb 21, 2024
Co-authored-by: Anna Henningsen <[email protected]>
addaleax
approved these changes
Feb 21, 2024
mcasimir
approved these changes
Feb 21, 2024
paula-stacho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Not a straight-forward copy-paste. But still the diff is too big, so let me tell you what has been done.
oidc-http-server-pages
New package was created with
npm run create-workspace.The contents (src) were taken from https://github.com/mongodb-js/devtools-connect/tree/main/src/oidc/static.
New
index.tswas added which exposes all the exports.The rest of adjustions was to make sure the npm scripts are working. Files were reformatted to fit the new prettier and linting, and selected dependencies from
devtools-connectwere added. The compilation follows devtools-connect in that it includesstatic-pages.jsand.esm-wrapper.mjs(this part I'm not sure if it's necessary).devtools-connect
Again, new package was created with
npm run create-workspace.The contents (src, scripts & package.json) were taken from https://github.com/mongodb-js/devtools-connect. Usages of
oidc-http-server-pageswere replaced with the new separate package.Again, I had to ensure the npm scripts are working. For this, I added the aliases used by lerna. Again, files were reformatted to fit new prettier. Linting was more difficult and I ended up just using the old config from
devtools-connect+ turning off a couple of extra rules that were in conflict with prettier.Lastly, the packages were tested by linking the devtools-connect package to mongosh and running
npm run testandnpm run test-e2e.