fix(saslprep): saslprep typing in node.d.ts NODE-5996 #254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
the recent changes to make saslprep compatible with the browser changed the generated types for Nodejs. When we tried to consume the latest saslprep in the driver, we get compile errors.
It seems like the combination of
_saslprep.bind
andObject.assign
erase the type ofsaslprep
such that the generated .d.ts file doesn't accurately reflect the types.node.d.ts
before the changes in this PR:node.d.ts
with the changes in this PR:Open Questions
Checklist