fix(devtools-proxy-support): handle special characters in SSH URL correctly COMPASS-8254 #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
changed the title
Anemy
approved these changes
Sep 5, 2024
lerouxb
reviewed
Sep 5, 2024
| @@ -92,7 +92,7 @@ export class SSHAgent extends AgentBase implements AgentWithInitialize { | |||
| this.logger.emit('ssh:establishing-conection', { | |||
| host: sshConnectConfig.host, | |||
| port: sshConnectConfig.port, | |||
| password: !!sshConnectConfig.passphrase, | |||
| password: !!sshConnectConfig.password, | |||
There was a problem hiding this comment.
To be fair, this bit is unrelated to the bug itself, but still, yeah, not my smartest move 😅
There was a problem hiding this comment.
Yeah I see now it is just in a logging event 👍
lerouxb
approved these changes
Sep 5, 2024
lerouxb
reviewed
Sep 5, 2024
| @@ -78,10 +78,10 @@ export class SSHAgent extends AgentBase implements AgentWithInitialize { | |||
| const sshConnectConfig: ConnectConfig = { | |||
| readyTimeout: 20000, | |||
| keepaliveInterval: 20000, | |||
| host: this.url.hostname, | |||
| host: decodeURIComponent(this.url.hostname), | |||
There was a problem hiding this comment.
I can see how this would be easy to miss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unfortunately very obvious in retrospect 😞