feat(shell-bson-parser): add support for binary constructors createFromHexString and createFromBase64 #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Feb 10, 2025
| @@ -120,6 +120,32 @@ describe('mongodb-query-parser', function () { | |||
| ); | |||
| }); | |||
|
|
|||
| // https://www.mongodb.com/docs/manual/reference/method/Binary.createFromHexString/ | |||
| it('should support Binary.createFromHexString', function () { | |||
| assert.deepEqual( | |||
There was a problem hiding this comment.
Not necessarily something for this PR, but just a reminder to myself that we'll probably want to turn all of these into assert.deepStrictEqual afterwards 😭
addaleax
changed the title
addaleax
added a commit
to mongodb-js/compass
that referenced
this pull request
Feb 10, 2025
11 tasks
addaleax
added a commit
to mongodb-js/compass
that referenced
this pull request
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes allow users of MongoDB Compass to use Binary.createFromHexString and Binary.createFromBase64 in queries
Without these, the only way to query for binary fields would be to use BinData, which forces base64 representation. By just updating the packages, Compass will be able to handle these queries (previously, the validation step would fail and there would be no way to run these queries except for in the shell)
Open Questions
The biggest change here is that I had to enable allowMethods for _parseFilter in
packages/query-parser/src/index.ts, but all tests seem to pass with the option set totrue.Checklist