Skip to content

chore: fixes ported from zstd #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Conversation

baileympearson
Copy link
Collaborator

@baileympearson baileympearson commented Nov 20, 2024

Description

What is changing?

  1. Because we're forced to test on Node16, we need to use Python 3.6 (3.8 is not available from the apt package registries). this requires node-gyp<=10.1. This PR pins to 10.1.
  2. The dockerfile squashes test errors for container builds. this is fixed.
  3. Once errors are no longer squashed, linux arm64 builds time out. The containers (or the qemu emulation) themselves are just incredibly slow (seeing the same issue locally and on zstd). I've adjusted the tests not to have a timeout.
Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Fill in title or leave empty for no highlight

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title misc fixes chore: fixes ported from zstd Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant