Skip to content
This repository was archived by the owner on Feb 3, 2022. It is now read-only.

NODE-2431: Reduce floating point precision required of extended json implementations #30

Merged
merged 10 commits into from
Jul 14, 2020
Merged

NODE-2431: Reduce floating point precision required of extended json implementations #30

merged 10 commits into from
Jul 14, 2020

Conversation

nbbeeken
Copy link

@nbbeeken nbbeeken commented Jul 8, 2020

@nbbeeken nbbeeken requested review from emadum and mbroadst July 8, 2020 17:13
emadum
emadum approved these changes Jul 9, 2020
View reviewed changes
Copy link

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mbroadst
mbroadst approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@mbroadst mbroadst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but what's going on with the build failure in Travis?

@nbbeeken
Copy link
Author

LGTM, but what's going on with the build failure in Travis?

Good question I actually have to rebase this change onto the 3.0 branch so that might pass the build fine, but it looks like the commits since 3.0 on master have introduced an update to 'buffer' that changed the import syntax. There are in fact breaking changes in master that we can't put into 3.0 so our plan to drop simply drop the 4.0 track isn't so straight forward.

@nbbeeken nbbeeken force-pushed the NODE-2431/EJSON-FloatingPointPrecision branch from f8c628a to c72ce17 Compare July 10, 2020 14:43
@nbbeeken nbbeeken changed the base branch from master to 3.0 July 10, 2020 14:43
@nbbeeken nbbeeken force-pushed the NODE-2431/EJSON-FloatingPointPrecision branch from 98046d5 to 99f6cce Compare July 10, 2020 15:29
@nbbeeken nbbeeken force-pushed the NODE-2431/EJSON-FloatingPointPrecision branch from 99f6cce to 0902753 Compare July 10, 2020 15:31
@nbbeeken nbbeeken requested a review from mbroadst July 13, 2020 13:37
@nbbeeken
Copy link
Author

I updated the driver we test against to 3.5 since that's the minimum version we support that also uses this ext-json lib. This also brings over commits that are published under the major ver 3 for this lib just to keep the 3.0 branch up to date. you should be able to to use the commit filter to view only the changes I've made since 3.0.3

@mbroadst mbroadst requested review from reggi and emadum July 14, 2020 14:29
mbroadst
mbroadst approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@mbroadst mbroadst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for the update, LGTM!

@nbbeeken
fix: Double precision EJSON fix and Spec update
b48ed7c 
Reduce the precision outputted for Double types

NODE-2431
@nbbeeken nbbeeken force-pushed the NODE-2431/EJSON-FloatingPointPrecision branch from 5995b8f to b48ed7c Compare July 14, 2020 14:34
@nbbeeken nbbeeken merged commit 988b8f8 into 3.0 Jul 14, 2020
@nbbeeken nbbeeken deleted the NODE-2431/EJSON-FloatingPointPrecision branch July 15, 2020 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbroadst mbroadst mbroadst approved these changes

@reggi reggi Awaiting requested review from reggi

@emadum emadum Awaiting requested review from emadum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nbbeeken @emadum @mbroadst @edaniels @daprahamian