-
Notifications
You must be signed in to change notification settings - Fork 41
feat: update the connect tool based on connectivity status #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0e79eab
feat: update the connect tool based on connectivity status
nirinchev 7b35cae
fix lint
nirinchev 409e01f
separate test teardown more cleanly
nirinchev 8f1d6ba
provide a better hint when the connection string is misconfigured
nirinchev a635889
Merge branch 'main' into ni/conditional-connect
nirinchev 40734c6
Merge branch 'main' into ni/conditional-connect
nirinchev 85b3993
Merge branch 'main' into ni/conditional-connect
nirinchev 0e42e11
CR comments
nirinchev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,8 +3,7 @@ import { Session } from "./session.js"; | |
import { Transport } from "@modelcontextprotocol/sdk/shared/transport.js"; | ||
import { AtlasTools } from "./tools/atlas/tools.js"; | ||
import { MongoDbTools } from "./tools/mongodb/tools.js"; | ||
import logger, { initializeLogger } from "./logger.js"; | ||
import { mongoLogId } from "mongodb-log-writer"; | ||
import logger, { initializeLogger, LogId } from "./logger.js"; | ||
import { ObjectId } from "mongodb"; | ||
import { Telemetry } from "./telemetry/telemetry.js"; | ||
import { UserConfig } from "./config.js"; | ||
|
@@ -23,7 +22,7 @@ export class Server { | |
public readonly session: Session; | ||
private readonly mcpServer: McpServer; | ||
private readonly telemetry: Telemetry; | ||
private readonly userConfig: UserConfig; | ||
public readonly userConfig: UserConfig; | ||
private readonly startTime: number; | ||
|
||
constructor({ session, mcpServer, userConfig }: ServerOptions) { | ||
|
@@ -71,7 +70,7 @@ export class Server { | |
this.session.sessionId = new ObjectId().toString(); | ||
|
||
logger.info( | ||
mongoLogId(1_000_004), | ||
LogId.serverInitialized, | ||
"server", | ||
`Server started with transport ${transport.constructor.name} and agent runner ${this.session.agentRunner?.name}` | ||
); | ||
|
@@ -135,6 +134,32 @@ export class Server { | |
} | ||
|
||
private registerResources() { | ||
this.mcpServer.resource( | ||
"config", | ||
"config://config", | ||
{ | ||
description: | ||
"Server configuration, supplied by the user either as environment variables or as startup arguments", | ||
}, | ||
(uri) => { | ||
const result = { | ||
telemetry: this.userConfig.telemetry, | ||
logPath: this.userConfig.logPath, | ||
connectionString: this.userConfig.connectionString | ||
? "set; no explicit connect needed, use switch-connection tool to connect to a different connection if necessary" | ||
: "not set; before using any mongodb tool, you need to call the connect tool with a connection string", | ||
connectOptions: this.userConfig.connectOptions, | ||
Comment on lines
+146
to
+151
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are the config options we're exposing as a resource |
||
}; | ||
return { | ||
contents: [ | ||
{ | ||
text: JSON.stringify(result), | ||
uri: uri.href, | ||
}, | ||
], | ||
}; | ||
} | ||
); | ||
if (this.userConfig.connectionString) { | ||
this.mcpServer.resource( | ||
"connection-string", | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not super happy with where we are at wrt configs, but this was a stopgap - there were a bunch of places in the tests where we were updating fields in the global config expecting this to be reflected in the server config, which only worked by accident.