Skip to content

feat: add atlas-connect-cluster tool #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 28, 2025
Merged

Conversation

fmenezes
Copy link
Collaborator

@fmenezes fmenezes commented Apr 25, 2025

Fixes #94

@fmenezes fmenezes marked this pull request as draft April 25, 2025 17:37
@coveralls
Copy link
Collaborator

coveralls commented Apr 25, 2025

Pull Request Test Coverage Report for Build 14705884283

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 26 of 31 (83.87%) changed or added relevant lines in 4 files are covered.
  • 60 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.9%) to 82.547%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/tools/atlas/metadata/connectCluster.ts 21 26 80.77%
Files with Coverage Reduction New Missed Lines %
src/session.ts 1 91.3%
src/tools/mongodb/mongodbTool.ts 3 85.19%
src/tools/tool.ts 3 90.14%
src/server.ts 5 83.58%
src/common/atlas/apiClient.ts 9 79.17%
src/config.ts 10 64.15%
src/logger.ts 11 70.77%
src/telemetry/telemetry.ts 18 39.62%
Totals Coverage Status
Change from base Build 14669535461: 0.9%
Covered Lines: 780
Relevant Lines: 894

💛 - Coveralls

@fmenezes fmenezes marked this pull request as ready for review April 28, 2025 13:33
@fmenezes fmenezes requested review from nirinchev, gagik, blva and a team as code owners April 28, 2025 13:34
@fmenezes fmenezes enabled auto-merge (squash) April 28, 2025 15:57
fmenezes and others added 2 commits April 28, 2025 17:02
@fmenezes fmenezes merged commit 8680e3a into main Apr 28, 2025
15 checks passed
@fmenezes fmenezes deleted the fmenezes/atlas_connect_tool branch April 28, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How do we allow connecting to an atlas cluster directly?
4 participants