ci: test to check dependencies #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to update the CI configuration for dependency testing while adjusting the test execution pattern.
- The test command has been updated to exclude the "tests/unit" folder.
- A new "dep-check" job has been added to install production dependencies and run an inspector tool.
Comments suppressed due to low confidence (2)
.github/workflows/code_health.yaml:57
- Excluding tests/unit from the test command may reduce overall unit test coverage. Please confirm that unit tests are being executed in another job or that this exclusion is intentional.
run: npm test -- --testPathIgnorePatterns "tests/unit" --testPathIgnorePatterns "tests/integration/tools/mongodb" --testPathIgnorePatterns "tests/integration/[^/]+\.ts"
.github/workflows/code_health.yaml:76
- The 'Install dependencies & build' step only runs 'npm ci' without an explicit build command. Consider adding a build command (e.g. 'npm run build') to ensure that the 'dist' directory is up-to-date for the subsequent inspector execution.
- name: Install dependencies & build
fmenezes
commented
Apr 29, 2025
| @@ -54,14 +54,34 @@ jobs: | |||
| MDB_MCP_API_CLIENT_ID: ${{ secrets.TEST_ATLAS_CLIENT_ID }} | |||
| MDB_MCP_API_CLIENT_SECRET: ${{ secrets.TEST_ATLAS_CLIENT_SECRET }} | |||
| MDB_MCP_API_BASE_URL: ${{ vars.TEST_ATLAS_BASE_URL }} | |||
| run: npm test -- --testPathIgnorePatterns "tests/integration/tools/mongodb" --testPathIgnorePatterns "tests/integration/[^/]+\.ts" | |||
| run: npm test -- --testPathIgnorePatterns "tests/unit" --testPathIgnorePatterns "tests/integration/tools/mongodb" --testPathIgnorePatterns "tests/integration/[^/]+\.ts" | |||
gagik
reviewed
Apr 29, 2025
| node-version-file: package.json | ||
| cache: "npm" | ||
| - name: Install dependencies & build | ||
| run: npm ci |
There was a problem hiding this comment.
I believe you're looking for npm ci --omit=dev
nirinchev
reviewed
Apr 29, 2025
Comment on lines
+76
to
+77
| - name: Install dependencies & build | ||
| run: npm ci |
There was a problem hiding this comment.
[nit] Is this not redundant considering we're removing node_modules and then running npm install again?
|
Might be worth considering https://www.npmjs.com/package/depcheck which is what we use in mongosh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #154
this test is basically:
distfolder