feat: add explain command #57
Conversation
gagik
force-pushed
the
gagik/add-explain
branch
from
b608fc9 to
599a179
Compare
| import { ToolArgs } from "../../tool.js"; | ||
|
|
||
| export const AggregateArgs = { | ||
| pipeline: z.array(z.object({}).passthrough()).describe("An array of aggregation stages to execute"), | ||
| limit: z.number().optional().default(10).describe("The maximum number of documents to return"), |
There was a problem hiding this comment.
I know you didn't change this, but I wonder if we should drop limit here? Considering the agg framework has a $limit stage, I wonder if that could conflict with a pipeline the model generates.
There was a problem hiding this comment.
My concern is the toArray() call then. it's going to try to load all the documents from the aggregation result into memory
There was a problem hiding this comment.
True - just wonder if we might run into trouble if a user asks for give me the top 50 docs and the model generates a stage, but our limit kicks in. Haven't looked into it, but we could check if there's a way to stream the responses to the model.
There was a problem hiding this comment.
I'll remove it and we can revisit with a solution
Co-authored-by: Nikola Irinchev <[email protected]>
gagik
force-pushed
the
gagik/null-assertions
branch
from
4de7d50 to
2a87387
Compare
Uh oh!
There was an error while loading. Please reload this page.