chore: remove configFile and state.json #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirinchev
reviewed
Apr 11, 2025
src/state.ts
Outdated
| return false; | ||
| } | ||
| } | ||
| connectionString?: string; |
There was a problem hiding this comment.
We should remove this - since it's no longer persisted, it is redundant.
| @@ -1,34 +1,8 @@ | |||
| import { NodeDriverServiceProvider } from "@mongosh/service-provider-node-driver"; | |||
| import { AsyncEntry } from "@napi-rs/keyring"; | |||
There was a problem hiding this comment.
We should remove this package dependency if we're not going to use it.
gagik
reviewed
Apr 11, 2025
src/config.ts
Outdated
| localDataPath, | ||
| configPath, | ||
| }; | ||
| fs.mkdirSync(logPath, { recursive: true }); |
There was a problem hiding this comment.
unrelated to the refactor but we should handle this call failing as we might not have permissions etc. and this is outside our try/catch
gagik
approved these changes
Apr 11, 2025
nirinchev
approved these changes
Apr 11, 2025
|
Looks like this is now conflicting with the integration tests. You can remove the mocks from |
same principle for the connection provider of MongoDB tools, seems like this state is a session rather than state |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplifying for now, we should be able to add them later