chore: add type-powered eslint rules #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
commented
Apr 11, 2025
fmenezes
reviewed
Apr 11, 2025
| "build:chmod": "chmod +x dist/index.js", | ||
| "build": "npm run build:clean && npm run build:compile && npm run build:addshebang && npm run build:chmod", | ||
| "build": "npm run build:clean && npm run build:compile && npm run build:chmod", |
There was a problem hiding this comment.
if you're removing shebang you should also remove chmod, that was meant to help before npm package is sorted
There was a problem hiding this comment.
…gagik/strict-eslint
nirinchev
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't been utilizing typescript-eslint's features to the fullest so adds some extra configuration to enable them and benefit from stricter types. It's already letting us see some not well defined behavior issues so that's good.