feat: add createCollection tool #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: add integration tests for listCollections
gagik
approved these changes
Apr 16, 2025
gagik
reviewed
Apr 16, 2025
| import { ObjectId } from "bson"; | ||
|
|
||
| describe("createCollection tool", () => { | ||
| const client = jestTestMCPClient(); |
There was a problem hiding this comment.
not blocking: this isn't from this PR but naming feels weird in retrospect as jest is an implementation detail. maybe mock or just getTestMCPClient?
There was a problem hiding this comment.
Well, it does also call the before/after hooks, so it kind of depends on jest (or a similar testing framework that has the same hooks with similar signatures). Also, I don't think it'd be accurate to call it a mock client as it's more of an integration setup. Happy to iterate on the naming though if we feel this is not the right one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: add integration tests for listCollections