-
Notifications
You must be signed in to change notification settings - Fork 77
PoC: Compass shell worker runtime (COMPASS-4517) #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0218ea1
build: Add webpack loader to import modules as inlined entries
gribnoysup 0db356c
chore: Update electron sandbox to provide all worker runtime required…
gribnoysup 5608704
feat: Add rpc over postMessage helper
gribnoysup fa0d137
feat: Implement child process runtime with an rpc message bridge
gribnoysup fcc922a
feat: Allow browser-repl to draw highlighted string as a cursor itera…
gribnoysup c68093f
fix: Use v8.serialize/deserialize to allow for Buffer transmission be…
gribnoysup c66d223
feat: Add evaluation termination logic
gribnoysup a082a84
chore(deps): Bump local dev electron version to match Compass
gribnoysup dbf56c0
feat(browser-runtime-electron): Allow to break runtime evaluation wit…
gribnoysup 13d2f10
refactor(compass-shell): Better serialization for the rpc, only {de}s…
gribnoysup e4b7e5f
build(compass-shell): Disable source maps in local dev to avoid build…
gribnoysup 415f5d1
refactor(compass-shell): Refactor child process creation to avoid wri…
gribnoysup File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
packages/compass-shell/config/loaders/inline-entry-loader.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
const loaderUtils = require('loader-utils'); | ||
|
||
const NodeTargetPlugin = require('webpack/lib/node/NodeTargetPlugin'); | ||
const SingleEntryPlugin = require('webpack/lib/SingleEntryPlugin'); | ||
|
||
function loader() {} | ||
|
||
loader.pitch = function pitch(request) { | ||
this.cacheable(false); | ||
|
||
const options = loaderUtils.getOptions(this) || {}; | ||
|
||
const cb = this.async(); | ||
|
||
const filename = loaderUtils.interpolateName( | ||
this, | ||
`${options.name || '[hash]'}.inline.js`, | ||
{ | ||
context: options.context || this.rootContext || this.options.context, | ||
regExp: options.regExp, | ||
} | ||
); | ||
|
||
const inlineEntry = {}; | ||
|
||
inlineEntry.options = { | ||
filename, | ||
chunkFilename: `[id].${filename}`, | ||
namedChunkFilename: null, | ||
}; | ||
|
||
inlineEntry.compiler = this._compilation.createChildCompiler( | ||
'inline', | ||
inlineEntry.options | ||
); | ||
|
||
if (this.target !== 'webworker' && this.target !== 'web') { | ||
new NodeTargetPlugin().apply(inlineEntry.compiler); | ||
} | ||
|
||
new SingleEntryPlugin(this.context, request, 'main').apply( | ||
inlineEntry.compiler | ||
); | ||
|
||
inlineEntry.compiler.runAsChild((err, entries, compilation) => { | ||
if (err) return cb(err); | ||
|
||
if (entries[0]) { | ||
inlineEntry.file = entries[0].files[0]; | ||
|
||
const contents = compilation.assets[inlineEntry.file].source(); | ||
|
||
inlineEntry.url = JSON.stringify(contents); | ||
|
||
return cb(null, `module.exports = ${inlineEntry.url};`); | ||
} | ||
|
||
return cb(null, null); | ||
}); | ||
}; | ||
|
||
module.exports = loader; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file here is mostly copying whatever the workerize-loader is doing, removing all parts that are not really relevant to us: it allows to convert an imported to module to an entry chunk so all its dependencies are bundled with it and then returns a stringified version of the code: