feat(node-runtime-worker-thread): Add new runtime that works in the worker thread COMPASS-4555 #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rerequisite for inlining workers
…ferring to it by the path
…void breaking shell api in prod build
…e hopes of fixing windows build
addaleax
approved these changes
Jan 8, 2021
| this.initWorkerPromise = this.initWorker(); | ||
| } | ||
|
|
||
| private async initWorker() { |
There was a problem hiding this comment.
Btw, I’m a bit surprised that the linter is okay with leaving out return value descriptions… I thought it complained about that for other packages
There was a problem hiding this comment.
Hmmm, I can't see the rule enabled in our eslint config, and it's not a recommended one 🤔 Should we add it?
There was a problem hiding this comment.
No strong feelings about that, but I personally like being explicit about the signature 🤷♀️
There was a problem hiding this comment.
Yeah, I like the rule too and (as it's pretty obvious from this PR, haha) always forget to add explicit return types when the rule is not there 😄
…of if statement, fix typos Co-authored-by: Anna Henningsen <[email protected]>
…rocess to terminate before resolving Co-authored-by: Anna Henningsen <[email protected]>
…runtime-worker-thread
… tests; Eval worker to mimic real usage better
gribnoysup
force-pushed
the
compass-4513-shell-runtime-worker-thread
branch
from
2413650 to
b51f847
Compare
…in hopes that this will fix win tests
gribnoysup
force-pushed
the
compass-4513-shell-runtime-worker-thread
branch
2 times, most recently
from
17c9c9c to
c12e90b
Compare
gribnoysup
force-pushed
the
compass-4513-shell-runtime-worker-thread
branch
2 times, most recently
from
5683a88 to
45f26dc
Compare
gribnoysup
force-pushed
the
compass-4513-shell-runtime-worker-thread
branch
from
07d5e33 to
d5aa34c
Compare
This was referenced Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new mongosh runtime that works in the worker thread and communicates with the main thread through an rpc that matches generic
RuntimeinterfaceTo avoid making this PR even bigger we decided to split the work on the runtime in the multiple parts:
ShellResults back to the main threadShellResultcases like primitive values, cursors and errorsmessageBusintegration for telemetrycompass-shellThis PR only addresses the first step: basic implementation. It's mostly based on the PoC (#483) and follows tech design decisions pretty closely if you want additional context on some of the decisions made
Please don't be scared by the line count, its mostly due to the new package being set up and files like package-lock added to the repository. The PR is still pretty massive so sorry for that and I'm of course happy to go through all the changes together