chore: publish to homebrew from CI MONGOSH-502 #541
Conversation
rose-m
force-pushed
the
mongosh-502-publish-to-homebrew-ci
branch
from
a8b70e3 to
c326261
Compare
| ...this.repo, | ||
| pull_number: prNumber | ||
| }); | ||
| } |
There was a problem hiding this comment.
Does whichever github user is running in CI have merge permissions for the repo?
There was a problem hiding this comment.
That's a great question, i don't think so, and i actually have no clue who we should ask, going to ask Jess, probably she knows
packages/build/src/homebrew/utils.ts
Outdated
| }); | ||
| } | ||
|
|
||
| export function cloneRepository(cloneDir: string, repositoryUrl: string): void { |
There was a problem hiding this comment.
Nope, good point - needs cleaning up!
| @@ -81,6 +82,7 @@ export default async function release( | |||
| } | |||
| await fs.writeFile(path.join(config.outputDir, '.artifact_metadata'), JSON.stringify(tarballFile)); | |||
| } else if (command === 'upload') { | |||
| const barque = new Barque(config); | |||
| @@ -17,11 +17,15 @@ chai.use(chaiAsPromised); | |||
| // to wait for these to finish. | |||
| const tick = promisify(setImmediate); | |||
|
|
|||
| // We keep an additional index as we might create two temp directories | |||
There was a problem hiding this comment.
this one confuses me :), is this related?
There was a problem hiding this comment.
It was... when I created git repos locally in tests I got conflicts as new Date() was not sufficient to create a unique folder name. I've left it in as it would prevent the same issue in the future.
I don't need it right now anymore so I can remove if you say we should strip.
There was a problem hiding this comment.
Fwiw, we do use Math.random() in a few other places as well. Doing that here would sound good to me in terms of consistency 👍
There was a problem hiding this comment.
(Or, to be clear, leaving it in this PR is also just fine with me!)
|
Quick update: I've tested the Github Repo auto-commit/pr/merge behavior, fixed some issues, and it's operational now. Here's a PR that was created with the |
This adds publishing to homebrew to the
buildpackage as part of thepublishcommand.Publishing to our https://github.com/mongodb/homebrew-brew repository is done by:
homebrew-brewrepository locallyhomebrew-brewhomebrew-brewfrom our new branch to masterI'd suggest waiting with this PR until #535 has landed, then rebase on top and merge since homebrew publishing requires the NPM packages to be released already.(PR has landed)