chore(ci): wrap bash scripts in curly brackets #554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evergreen implements bash script execution by piping into bash. This is not good, because it means that commands might actually end up in a subprocess’s stdin instead of bash itself, leading to commands being skipped. Use curly brackets to make sure that bash has read the entire script before it starts executing it. (See https://jira.mongodb.org/browse/EVG-13667)
|
(To be clear, I’m not sure that this is currently causing any trouble, but in the past it did; e.g. before 837eb06 we ran the e2e tests on the generated executable on Linux but not on macOS because of this.) |
aherlihy
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evergreen implements bash script execution by piping into bash.
This is not good, because it means that commands might actually
end up in a subprocess’s stdin instead of bash itself, leading to
commands being skipped. Use curly brackets to make sure that bash
has read the entire script before it starts executing it.
(See https://jira.mongodb.org/browse/EVG-13667)