Skip to content

chore(ci): run tests against enterprise server versions #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@
"lerna": "^3.10.7",
"mocha": "^7.1.2",
"mongodb": "github:mongodb/node-mongodb-native#62717a1d",
"mongodb-download-url": "^0.6.1",
"mongodb-download-url": "^0.6.3",
"mongodb-js-precommit": "^2.0.0",
"node-codesign": "^0.3.2",
"node-fetch": "^2.6.1",
Expand Down
4 changes: 2 additions & 2 deletions packages/node-runtime-worker-thread/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
},
"scripts": {
"pretest": "npm run webpack-build-dev -- --no-stats --no-devtool",
"test": "cross-env TS_NODE_PROJECT=./tsconfig.test.json mocha --timeout 15000 --colors -r ts-node/register \"./src/**/*.spec.ts\"",
"test": "cross-env TS_NODE_PROJECT=./tsconfig.test.json mocha -r \"../../scripts/import-expansions.js\" --timeout 15000 --colors -r ts-node/register \"./src/**/*.spec.ts\"",
"pretest-ci": "npm run webpack-build -- --no-stats --no-devtool",
"test-ci": "cross-env TS_NODE_PROJECT=./tsconfig.test.json mocha --timeout 15000 -r ts-node/register \"./src/**/*.spec.ts\"",
"test-ci": "cross-env TS_NODE_PROJECT=./tsconfig.test.json mocha -r \"../../scripts/import-expansions.js\" --timeout 15000 -r ts-node/register \"./src/**/*.spec.ts\"",
"lint": "eslint \"./src/**/*.{js,ts,tsx}\"",
"check": "npm run lint",
"webpack-build": "webpack --mode production",
Expand Down
23 changes: 17 additions & 6 deletions testing/download-mongodb.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,27 +57,38 @@ type FullJSON = {
// On Linux, getting the exact download variant to pick is hard, so we still
// use mongodb-download-url for that. For macOS, either would probably be fine.
// TODO: upstream all of this into mongodb-download-url :(
async function lookupDownloadUrl(versionInfo: VersionInfo): Promise<string> {
const knownDistroRegex = /^(?<name>rhel80|rhel7[0-9]|debian10)/;
async function lookupDownloadUrl(versionInfo: VersionInfo, enterprise: boolean): Promise<string> {
const knownDistroRegex = /^(?<name>rhel80|rhel7[0-9]|debian10|ubuntu(?:\d+))/;
const { version } = versionInfo;
const distroId = process.env.DISTRO_ID || '';
if ((process.platform === 'win32' && semver.lt(version, '4.4.0')) ||
(process.platform === 'linux' && semver.lt(version, '4.2.0')) ||
(process.platform !== 'win32' && !knownDistroRegex.test(distroId))) {
return (await promisify(getDownloadURL)({ version })).url;
let { url } = (await promisify(getDownloadURL)({ version, enterprise }));
if (semver.gte(version, '4.2.0')) {
url = url.replace('mongodb-osx', 'mongodb-macos');
}
if (semver.lt(version, '4.2.0') && distroId) {
url = url.replace('enterprise-linux_64', `enterprise-${distroId.split('-')[0]}`);
}
return url;
}

let downloadInfo: DownloadInfo;
if (process.platform === 'win32') {
downloadInfo = versionInfo.downloads
.find((downloadInfo: DownloadInfo) =>
downloadInfo.target === 'windows' && downloadInfo.edition === 'base') as DownloadInfo;
downloadInfo.target === 'windows' &&
downloadInfo.edition === (enterprise ? 'enterprise' : 'base') &&
downloadInfo.arch === 'x86_64') as DownloadInfo;
} else {
let distro = distroId.match(knownDistroRegex)!.groups!.name;
if (distro.match(/rhel7[0-9]/)) distro = 'rhel70';
downloadInfo = versionInfo.downloads
.find((downloadInfo: DownloadInfo) =>
downloadInfo.target === distro && downloadInfo.edition === 'targeted') as DownloadInfo;
downloadInfo.target === distro &&
downloadInfo.edition === (enterprise ? 'enterprise' : 'targeted') &&
downloadInfo.arch === 'x86_64') as DownloadInfo;
}
return downloadInfo.archive.url;
}
Expand Down Expand Up @@ -116,7 +127,7 @@ export async function downloadMongoDb(targetVersionSemverSpecifier = '*'): Promi
.filter((info: VersionInfo) => semver.satisfies(info.version, targetVersionSemverSpecifier))
.sort((a: VersionInfo, b: VersionInfo) => semver.rcompare(a.version, b.version));
const versionInfo: VersionInfo = productionVersions[0];
return await doDownload(versionInfo.version, () => lookupDownloadUrl(versionInfo));
return await doDownload(versionInfo.version, () => lookupDownloadUrl(versionInfo, true));
}

const downloadPromises: Record<string, Promise<string>> = {};
Expand Down