PYTHON-4391: [Bugfix] Use Docker to run LocalAtlas #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jibola
changed the title
Jibola
changed the title
caseyclements
requested changes
Aug 21, 2024
.evergreen/config.yml
Outdated
| @@ -55,7 +55,7 @@ functions: | |||
| working_dir: "src/${DIR}/${REPO_NAME}" | |||
| binary: bash | |||
| env: | |||
| atlas: ${workdir}/src/atlas/bin/atlas | |||
| atlas: ${workdir}/src/atlas/bin/atlas | |||
There was a problem hiding this comment.
we need a linter. :)
There was a problem hiding this comment.
Agreed. I'll make a task for it. PYTHON-4687
Jibola
commented
Aug 22, 2024
Jibola
commented
Aug 22, 2024
caseyclements
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our former method of using local atlas. (by downloading the binary and then making the $atlas calls) has been failing. We're now moving our operations to leverage podman. As such, we no longer get the same exposed atlas commands and have moved the index creation work to the python
scaffold_atlas.pyscript.Moreover, I've updated the README to specify a new way to get the URI and pass it as a flag to each script.
Expected Errors
Since local atlas had been failing for some time, the errors had hidden other regressions that have popped up in our integrations. As a result, we've examined each and have provided new bug tickets for their resolution.