Skip to content

PYTHON-4678: Fix Import Errors in semantic-kernel/python #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 2, 2024
Merged

PYTHON-4678: Fix Import Errors in semantic-kernel/python #34

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4d15c4b
switched to importing .[mongodb]
Jibola Sep 20, 2024
334a6d8
Merge branch 'main' into semantic-kernel-python-import-fix
Jibola Sep 20, 2024
c73067f
don't import dotenv
Jibola Sep 20, 2024
4850505
leverage uv stages to run tests
Jibola Oct 2, 2024
6f4b352
Merge branch 'main' into semantic-kernel-python-import-fix
Jibola Oct 2, 2024
a186c0e
remove venv creation step
Jibola Oct 2, 2024
ca6fa0d
piece out the make commands
Jibola Oct 2, 2024
1a0b75c
Merge branch 'semantic-kernel-python-import-fix' of https://github.co…
Jibola Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 22 additions & 32 deletions semantic-kernel-python/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,42 +7,32 @@ set -x
CONN_STRING=$(fetch_local_atlas_uri)
PYTHON_BINARY=$(find_python3)


# WORKING_DIR = src/semantic-kernel-python/semantic-kernel
cd python

# Temporary solution until https://github.com/microsoft/semantic-kernel/issues/9067 resolves
$PYTHON_BINARY -m venv venv_wrapper
source venv_wrapper/bin/activate
pip install --upgrade uv

# Install Poetry into base python
$PYTHON_BINARY -m pip install -U pip poetry
# Create a package specific poetry environment
$PYTHON_BINARY -m poetry env use $PYTHON_BINARY
# Activate the poetry env, which itself does not include poetry
source $($PYTHON_BINARY -m poetry env info --path)/bin/activate
# Recreate the poetry lock file
$PYTHON_BINARY -m poetry lock --no-update
# Install from pyproject.toml into package specific environment
$PYTHON_BINARY -m poetry install --with dev

# Create .env file
python -c "from dotenv import set_key; set_key('.env', 'OPENAI_API_KEY', '$openai_api_key')"
python -c "from dotenv import set_key; set_key('.env', 'MONGODB_ATLAS_CONNECTION_STRING', '$CONN_STRING')"
make install-python
make install-sk
make install-pre-commit

# Workaround to test vector search first
OPENAI_API_KEY=$openai_api_key \
OPENAI_ORG_ID="" \
AZURE_OPENAI_DEPLOYMENT_NAME="" \
AZURE_OPENAI_ENDPOINT="" \
AZURE_OPENAI_API_KEY="" \
MONGODB_ATLAS_CONNECTION_STRING=$CONN_STRING \
Python_Integration_Tests=1 \
$PYTHON_BINARY -m poetry run pytest tests/integration/connectors/memory/test_mongodb_atlas.py -k test_collection_knn

# Stored in evergreen VARIABLES
OPENAI_ORG_ID="" \
AZURE_OPENAI_DEPLOYMENT_NAME="" \
AZURE_OPENAI_ENDPOINT="" \
AZURE_OPENAI_API_KEY="" \
MONGODB_ATLAS_CONNECTION_STRING=$CONN_STRING \
Python_Integration_Tests=1 \
uv run pytest tests/integration/connectors/memory/test_mongodb_atlas.py -k test_collection_knn

OPENAI_API_KEY=$openai_api_key \
OPENAI_ORG_ID="" \
AZURE_OPENAI_DEPLOYMENT_NAME="" \
AZURE_OPENAI_ENDPOINT="" \
AZURE_OPENAI_API_KEY="" \
MONGODB_ATLAS_CONNECTION_STRING=$CONN_STRING \
Python_Integration_Tests=1 \
$PYTHON_BINARY -m poetry run pytest tests/integration/connectors/memory/test_mongodb_atlas.py
OPENAI_ORG_ID="" \
AZURE_OPENAI_DEPLOYMENT_NAME="" \
AZURE_OPENAI_ENDPOINT="" \
AZURE_OPENAI_API_KEY="" \
MONGODB_ATLAS_CONNECTION_STRING=$CONN_STRING \
Python_Integration_Tests=1 \
uv run pytest tests/integration/connectors/memory/test_mongodb_atlas.py