PYTHON-4679 Fixes all Langchain Tests #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
caseyclements
commented
Oct 1, 2024
caseyclements
commented
- All tests are passing
- All tests are running on Atlas CLI!
- I have temporarily skipped tests that called update_search_index
- Duration: 1m 33s
…::ci-on-local-atlas
Jibola
approved these changes
Oct 2, 2024
| @@ -142,8 +142,8 @@ buildvariants: | |||
| display_name: Langchain RHEL Python | |||
| expansions: | |||
| DIR: langchain-python | |||
| REPO_NAME: langchain | |||
| CLONE_URL: https://github.com/langchain-ai/langchain.git | |||
| REPO_NAME: langchain # TODO [PYTHON-4679] Merge change in this branch | |||
There was a problem hiding this comment.
could you add your LangChain PR to the JIRA ticket?
| { | ||
| "fields": [ | ||
| { | ||
| "numDimensions": 5, |
There was a problem hiding this comment.
I see some tests now have 5 dimensions whilst others have 1536. Any hesitation to making them all use 5?
There was a problem hiding this comment.
The ones that use 5 are that way because we're not testing the quality of the search. If not, anything to make it faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.