Add action to upload S3 assets #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
blink1073
reviewed
Jun 10, 2024
README.md
Outdated
| ``` | ||
|
|
||
| Optionally, you can specify which files to upload using the `filenames` input. | ||
| By default, all files in the S3 directory are uploaded. |
There was a problem hiding this comment.
Why not support dry_run and print out the files that would have been uploaded if it is set?
There was a problem hiding this comment.
I didn't think it was necessary, but I can see how it can be useful during the initial phase of setting up the tooling. I've added the dry_run parameter with slightly changed logic: it prints the filename along with the name it would receive in the bucket (minus the bucket name since we'd be relying on it being redacted) and doesn't cat the file to avoid exposing data that should be kept internal.
alcaeus
force-pushed
the
upload-s3-assets
branch
from
e189779 to
a6e2937
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This action is similar to the one created for node in #14, with a couple of notable differences:
filenamesinput can be used to change this but the action will only upload assets from that temporarys3_assetsdirectory@baileympearson I haven't touched the node action, but it could be replaced with this one once the PR is merged.