Skip to content

ARROW-246 Remove upper version pin on packaging #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bindings/python/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@

---

# Changes in Version 1.5.1

- Remove upper bound version pin on `packaging`.

# Changes in Version 1.5.0

- Support for PyArrow 17.0
Expand Down
8 changes: 3 additions & 5 deletions bindings/python/pymongoarrow/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,10 @@
from pymongoarrow.version import _MIN_LIBBSON_VERSION, __version__ # noqa: F401

try:
# Not needed for building the package.
from packaging.version import parse as _parse_version
except ImportError:
from distutils.version import LooseVersion as _LooseVersion

def _parse_version(version):
return _LooseVersion(version)
_parse_version = None


try:
Expand All @@ -42,7 +40,7 @@ def _parse_version(version):
)
libbson_version = None

if libbson_version is not None: # noqa: SIM102
if libbson_version is not None and _parse_version is not None: # noqa: SIM102
if _parse_version(libbson_version) < _parse_version(_MIN_LIBBSON_VERSION):
msg = (
f"Expected libbson version {_MIN_LIBBSON_VERSION} or greater, "
Expand Down
2 changes: 1 addition & 1 deletion bindings/python/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ dependencies = [
"pyarrow >=17.0,<17.1",
"pymongo >=4.4,<5",
"pandas >=1.3.5,<3",
"packaging >=23.2,<24",
"packaging >=23.2",
]
dynamic = ["version"]

Expand Down
Loading