Skip to content

INTPYTHON-538 Add support for PyArrow Decimal128 type #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

blink1073
Copy link
Member

No description provided.

Copy link
Contributor

@caseyclements caseyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool. TIL
LTGM after an update to the comment about handling Pandas NA. The TypeRegistry is bound to grow.

@@ -471,7 +485,7 @@ def write(collection, tabular, *, exclude_none: bool = False):

# Handle Pandas NA objects.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, "Add handling for special case types"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor

@caseyclements caseyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blink1073 blink1073 merged commit caf1cc5 into mongodb-labs:main Feb 26, 2025
44 checks passed
@blink1073 blink1073 deleted the INTPYTHON-538 branch February 26, 2025 16:17
@ShaneHarvey
Copy link
Collaborator

LGTM2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants