(DOCSP-43745) Connect to MongoDB #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-c ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mcmorisi
approved these changes
Oct 1, 2024
Comment on lines
21
to
22
| fprintf (stderr, "%s\n", error.message); | ||
| goto cleanup; |
There was a problem hiding this comment.
Q: Should these have the same indentation?
There was a problem hiding this comment.
yup fixed it!
source/connect.txt
Outdated
Comment on lines
103
to
104
| mongoc_client_t *client = mongoc_client_new (uri); |
There was a problem hiding this comment.
Nit: we use underlines for the placeholders elsewhere in this page, I think we should stick to that.
Suggested change
| char *uri = "mongodb://<replica-set-member>:<port>/?replicaSet=<replica-set-name>"; | |
| mongoc_client_t *client = mongoc_client_new (uri); | |
| char *uri = "mongodb://<replica_set_member>:<port>/?replicaSet=<replica_set_name>"; | |
| mongoc_client_t *client = mongoc_client_new (uri); |
source/connect.txt
Outdated
| .. code-block:: c | ||
|
|
||
| mongoc_client_t *client = mongoc_client_new("mongodb://<db_username>:<db_password>@<hostname>:<port>/?server_selector=<selector-function>"); |
There was a problem hiding this comment.
Same nit as above
Suggested change
| mongoc_client_t *client = mongoc_client_new("mongodb://<db_username>:<db_password>@<hostname>:<port>/?server_selector=<selector-function>"); | |
| mongoc_client_t *client = mongoc_client_new("mongodb://<db_username>:<db_password>@<hostname>:<port>/?server_selector=<selector_function>"); |
kevinAlbs
reviewed
Oct 1, 2024
amalhotra-mdb
force-pushed
the
DOCSP-43745
branch
from
1e052b3 to
04f50c6
Compare
|
@kevinAlbs thanks so much for all your help and thoroughness on these C standardization PRs! |
kevinAlbs
reviewed
Oct 2, 2024
source/connect.txt
Outdated
Comment on lines
72
to
73
| client = mongoc_client_new_from_uri (uri); |
There was a problem hiding this comment.
Suggested change
| uri = mongoc_uri_new ("mongodb://localhost:27017"); | |
| client = mongoc_client_new_from_uri (uri); | |
| client = mongoc_client_new ("mongodb://localhost:27017"); |
Suggest not using uri for consistency with tabbed examples.
kevinAlbs
approved these changes
Oct 2, 2024
source/connect.txt
Outdated
Comment on lines
72
to
73
| client = mongoc_client_new_from_uri (uri); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
Fill out root page for "Connect to MongoDB" (created as stub in this ticket).
A/C: I can see all the operations for connecting to MongoDB in a section.
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-43745
Staging - https://deploy-preview-61--docs-c.netlify.app/connect/
Self-Review Checklist