Skip to content

DOCSP 13860: UpdateMany usage example #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 28, 2021

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Jul 26, 2021

Pull Request Info

Issue JIRA link:

https://jira.mongodb.org/browse/DOCSP-13860

Docs staging link (requires sign-in on MongoDB Corp SSO):

https://docs-mongodbcom-staging.corp.mongodb.com/golang/docsworker-xlarge/DOCSP-13860-updatemany-usage-ex/usage-examples/updateMany/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Does it render on staging correctly?
  • Are all the links working?
  • Are the staging links in the PR description updated?

Copy link
Contributor

@kyuan-mongodb kyuan-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Just a suggestion and question.

Copy link
Contributor

@kyuan-mongodb kyuan-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a formatting edit.

@rustagir rustagir requested a review from kevinAlbs July 26, 2021 17:54
@rustagir
Copy link
Contributor Author

Hi @kevinAlbs, this PR is ready for review!

@rustagir rustagir changed the title DOCSP: 13860 updatemany usage example DOCSP 13860: UpdateMany usage example Jul 26, 2021
Copy link
Collaborator

@kevinAlbs kevinAlbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod the TODO links being updated.

:language: go
:dedent:

Click here **<TODO: github link to file>** to see a fully runnable example.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume similar to #5 (comment) this link, and the TODO link below will be updated before publishing.

@rustagir rustagir merged commit 9dd2d63 into mongodb:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants