Skip to content

DOCSP 13856: find usage example #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 29, 2021
Merged

DOCSP 13856: find usage example #8

merged 6 commits into from
Jul 29, 2021

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Jul 26, 2021 •
edited
Loading

Pull Request Info

Issue JIRA link:

https://jira.mongodb.org/browse/DOCSP-13856

Docs staging link (requires sign-in on MongoDB Corp SSO):

https://docs-mongodbcom-staging.corp.mongodb.com/golang/docsworker-xlarge/DOCSP-13856-find-usage-ex/usage-examples/find/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Does it render on staging correctly?
  • Are all the links working?
  • Are the staging links in the PR description updated?

biniona-mongodb
biniona-mongodb suggested changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@biniona-mongodb biniona-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job. Looks great. After these should be good to go through.

biniona-mongodb
biniona-mongodb suggested changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@biniona-mongodb biniona-mongodb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this one item and resolve the last items from past round and then good to go.

biniona-mongodb
biniona-mongodb approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@biniona-mongodb biniona-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rustagir rustagir requested a review from kevinAlbs July 28, 2021 17:59
@rustagir
Copy link
Contributor Author

Hi @kevinAlbs, this PR is ready for review.

@kevinAlbs kevinAlbs requested review from benjirewis and removed request for kevinAlbs July 28, 2021 17:59
benjirewis
benjirewis reviewed Jul 28, 2021
View reviewed changes
@rustagir rustagir merged commit 5016d29 into mongodb:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjirewis benjirewis benjirewis approved these changes

@biniona-mongodb biniona-mongodb biniona-mongodb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rustagir @benjirewis @biniona-mongodb