Skip to content

DOCSP-24433: SEO meta descriptions #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 22, 2023

Conversation

ccho-mongodb
Copy link
Contributor

@ccho-mongodb ccho-mongodb commented May 4, 2023

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-24433
Staging - None (meta descriptions only)

Currently, meta descriptions are not rendering on staging nor the published site, so will wait to merge this.

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

@ccho-mongodb ccho-mongodb marked this pull request as ready for review May 4, 2023 19:59
Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some non-blocking comments. everything looks good, but I think some adjustments could be made to make the language a little more natural

@@ -2,7 +2,8 @@
Delete Operations
=================

.. default-domain:: mongodb
.. meta::
:description: See examples of deleting data from MongoDB by using the {+driver-long+}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment; the phrase "deleting data from" sounds awkward. could it still be "deleting data IN.."?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I think I've always heard the preposition "from" associated with "delete".
E.g. "Delete from your computer" vs "Delete in your computer"
Have you heard the latter before?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way i was thinking about it was that we are working "in" MongoDB and any operations are executed from that point of view. But I see your point too!

@@ -2,7 +2,8 @@
Find Operations
===============

.. default-domain:: mongodb
.. meta::
:description: See examples of querying and retrieving data from MongoDB by using the {+driver-long+}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C: since "querying" and "retrieving data from" aren't exactly parallel, could we just remove one of them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they are two separate actions, so maybe "querying data and retrieving data" would be appropriate.
Querying is the action of formulating instructions and sending the command to performing matching whereas retrieving is accessing the results, perhaps from a cursor.

@@ -2,7 +2,8 @@
Insert Operations
=================

.. default-domain:: mongodb
.. meta::
:description: See examples of inserting data into MongoDB by using the {+driver-long+}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: for the usage examples, does this sound a little more natural?

Suggested change
:description: See examples of inserting data into MongoDB by using the {+driver-long+}.
:description: See how to insert data into MongoDB by using the {+driver-long+}.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By natural, did you mean avoiding using "examples" when the title of the page might include "examples"?
I don't have a strong preference for either your suggestion or the original text.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think including the word example is unnecessary-- including the word "how" might make it easier for users to pick up the point of these pages

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I think maybe I'll update this and all similar instances to "Learn how" since I think that seems more frequently used in our style guide examples.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, the title of the page and how it would show up in search results is "Insert Operations", not "Usage Examples", so I think "examples" is important to mention. I will try rephrasing it a bit to avoid the gerund.

@@ -2,7 +2,8 @@
Write Operations
================

.. default-domain:: mongodb
.. meta::
:description: Learn the concepts related to storing data to MongoDB by using the {+driver-long+}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:description: Learn the concepts related to storing data to MongoDB by using the {+driver-long+}.
:description: Learn the concepts related to writing data to MongoDB by using the {+driver-long+}.

Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting to express my thoughts on how to describe running an operation

@@ -2,7 +2,8 @@
Read Operations
===============

.. default-domain:: mongodb
.. meta::
:description: Learn about the commands for running MongoDB read operations by using the {+driver-long+}.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: There are some inconsistencies about where MongoDB goes in the phrase "___ operation" across these descriptions. Maybe moving MongoDB out of the phrase will make it easier for users to understand that you are running an operation by using the driver to do something in/from/to MongoDB

Suggested change
:description: Learn about the commands for running MongoDB read operations by using the {+driver-long+}.
:description: Learn about the commands for running read operations on MongoDB by using the {+driver-long+}.

Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting to express my thoughts on how to describe running an operation

@ccho-mongodb ccho-mongodb merged commit f9a818c into mongodb:master Sep 22, 2023
@ccho-mongodb ccho-mongodb deleted the DOCSP-24433-meta branch September 22, 2023 15:40
ccho-mongodb pushed a commit that referenced this pull request Sep 22, 2023
* DOCSP-24433: SEO meta descriptions

(cherry picked from commit f9a818c)
ccho-mongodb pushed a commit that referenced this pull request Sep 22, 2023
* DOCSP-24433: SEO meta descriptions

(cherry picked from commit f9a818c)
ccho-mongodb pushed a commit that referenced this pull request Sep 22, 2023
* DOCSP-24433: SEO meta descriptions

(cherry picked from commit f9a818c)
ccho-mongodb pushed a commit that referenced this pull request Sep 22, 2023
* DOCSP-24433: SEO meta descriptions

(cherry picked from commit f9a818c)
ccho-mongodb pushed a commit that referenced this pull request Sep 22, 2023
* DOCSP-24433: SEO meta descriptions

(cherry picked from commit f9a818c)
ccho-mongodb pushed a commit that referenced this pull request Sep 22, 2023
* DOCSP-24433: SEO meta descriptions

(cherry picked from commit f9a818c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants