Skip to content

DOCSP-32036: fix link on monitoring page #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Aug 8, 2023

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-32036
Staging (link at bottom of section)

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • [] Did you run a spell-check?
  • [] Did you run a grammar-check?
  • Are all the links working?

Copy link
Contributor

@ccho-mongodb ccho-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion.

@@ -172,7 +172,7 @@ implements one of the three preceding interfaces and register an instance of tha
class with your ``MongoClient`` instance.

For a detailed description of each SDAM event in the driver, see the
:spec:`MongoDB SDAM monitoring specification </server-discovery-and-monitoring/server-discovery-and-monitoring-monitoring.rst#events>`.
:spec:`MongoDB SDAM monitoring specification </server-discovery-and-monitoring/server-discovery-and-monitoring-logging-and-monitoring.rst#events-api>`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

I think this should match the new title of the doc "SDAM Logging and Monitoring Specification" (they added logging to the title and filename which is why the link was broken).

@rustagir rustagir merged commit 495cfe3 into mongodb:master Aug 8, 2023
rustagir added a commit that referenced this pull request Aug 8, 2023
* DOCSP-32036: fix link on monitoring page

* CC suggestion

(cherry picked from commit 495cfe3)
rustagir added a commit that referenced this pull request Aug 8, 2023
* DOCSP-32036: fix link on monitoring page

* CC suggestion

(cherry picked from commit 495cfe3)
rustagir added a commit that referenced this pull request Aug 8, 2023
* DOCSP-32036: fix link on monitoring page

* CC suggestion

(cherry picked from commit 495cfe3)
rustagir added a commit that referenced this pull request Aug 8, 2023
* DOCSP-32036: fix link on monitoring page

* CC suggestion

(cherry picked from commit 495cfe3)
rustagir added a commit that referenced this pull request Aug 8, 2023
* DOCSP-32036: fix link on monitoring page

* CC suggestion

(cherry picked from commit 495cfe3)
rustagir added a commit that referenced this pull request Aug 8, 2023
* DOCSP-32036: fix link on monitoring page

* CC suggestion

(cherry picked from commit 495cfe3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants