Skip to content

DOCSP-32129: fix ServerAddress placeholder for port parameter #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ccho-mongodb
Copy link
Contributor

@ccho-mongodb ccho-mongodb commented Aug 10, 2023

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-32129

Note: in some instances, the "atlasUri" placeholder was replaced by "hostname" since an Atlas URI likely contains more information than just the hostname, and would therefore error according to the API documentation.

Staging:

Authentication Mechanisms - select MongoCredential tab to see the relevant code snippets.

Enterprise Authentication Mechanisms - select MongoCredential tab to see the relevant code snippets.

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

@ccho-mongodb ccho-mongodb marked this pull request as ready for review August 10, 2023 19:14
Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ccho-mongodb ccho-mongodb merged commit 830cdae into mongodb:master Aug 10, 2023
@ccho-mongodb ccho-mongodb deleted the DOCSP-32129-fix-serveraddress-port-placeholder branch August 10, 2023 21:15
ccho-mongodb pushed a commit that referenced this pull request Aug 10, 2023
ccho-mongodb pushed a commit that referenced this pull request Aug 10, 2023
ccho-mongodb pushed a commit that referenced this pull request Aug 10, 2023
ccho-mongodb pushed a commit that referenced this pull request Aug 10, 2023
ccho-mongodb pushed a commit that referenced this pull request Aug 10, 2023
ccho-mongodb pushed a commit that referenced this pull request Aug 10, 2023
ccho-mongodb pushed a commit that referenced this pull request Aug 10, 2023
ccho-mongodb pushed a commit that referenced this pull request Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants