Skip to content

DOCSP-31430: Explain new API benefits #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 15, 2023

Conversation

norareidy
Copy link
Contributor

@norareidy norareidy commented Sep 11, 2023

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-31430
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/java/docsworker-xlarge/DOCSP-31430-new-sync-features/legacy/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

@norareidy norareidy closed this Sep 11, 2023
@norareidy norareidy reopened this Sep 11, 2023
Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. A few small suggestions.

Copy link
Contributor

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@norareidy norareidy requested a review from jyemin September 14, 2023 21:59
@norareidy norareidy merged commit 7286a63 into mongodb:master Sep 15, 2023
@norareidy norareidy deleted the DOCSP-31430-new-sync-features branch September 15, 2023 17:11
norareidy added a commit that referenced this pull request Sep 15, 2023
* DOCSP-31430: Explain new API benefits

* rewording

* build

* DOCSP-31430: Explain new API benefits

* rewording

* build

* addressing feedback

* vale suggestions

* typo

* typo

* tech feedback

* adding pojos

* wording fix

(cherry picked from commit 7286a63)
norareidy added a commit that referenced this pull request Sep 15, 2023
* DOCSP-31430: Explain new API benefits

* rewording

* build

* DOCSP-31430: Explain new API benefits

* rewording

* build

* addressing feedback

* vale suggestions

* typo

* typo

* tech feedback

* adding pojos

* wording fix

(cherry picked from commit 7286a63)
norareidy added a commit that referenced this pull request Sep 15, 2023
* DOCSP-31430: Explain new API benefits

* rewording

* build

* DOCSP-31430: Explain new API benefits

* rewording

* build

* addressing feedback

* vale suggestions

* typo

* typo

* tech feedback

* adding pojos

* wording fix

(cherry picked from commit 7286a63)
norareidy added a commit that referenced this pull request Sep 15, 2023
* DOCSP-31430: Explain new API benefits

* rewording

* build

* DOCSP-31430: Explain new API benefits

* rewording

* build

* addressing feedback

* vale suggestions

* typo

* typo

* tech feedback

* adding pojos

* wording fix

(cherry picked from commit 7286a63)
norareidy added a commit that referenced this pull request Sep 15, 2023
* DOCSP-31430: Explain new API benefits

* rewording

* build

* DOCSP-31430: Explain new API benefits

* rewording

* build

* addressing feedback

* vale suggestions

* typo

* typo

* tech feedback

* adding pojos

* wording fix

(cherry picked from commit 7286a63)
norareidy added a commit that referenced this pull request Sep 15, 2023
* DOCSP-31430: Explain new API benefits

* rewording

* build

* DOCSP-31430: Explain new API benefits

* rewording

* build

* addressing feedback

* vale suggestions

* typo

* typo

* tech feedback

* adding pojos

* wording fix

(cherry picked from commit 7286a63)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants